Fix vector comparison expression for HLSL. #2270
Open
num3ric wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Fix vector comparison expression for HLSL. #2270num3ric wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
num3ric wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
doug-walker
approved these changes
Mar 1, 2026
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thank you for this fix, Eric! Already a nice benefit from the HLSL test harness you're working on!
Please remember that you must sign your commits for the DCO check to pass. To fix it, you may be able to amend your commit with the signoff and then force push.
Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com>
num3ric
force-pushed
the
fix/hlsl-vector-compare
branch
from
4ac06f0 to
ff7726f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSL and HLSL do not allow vector bool in if-conditions: wrap with any().
Isolated fix from my new DX12 GPU test support branch: https://github.com/num3ric/OpenColorIO/commits/dx/